EnricoMi commented on code in PR #1663:
URL:
https://github.com/apache/incubator-uniffle/pull/1663#discussion_r1571835422
##########
client-spark/common/src/test/java/org/apache/uniffle/shuffle/manager/ShuffleManagerServerFactoryTest.java:
##########
@@ -17,26 +17,28 @@
package org.apache.uniffle.shuffle.manager;
-import org.junit.jupiter.api.Test;
+import java.util.stream.Stream;
+
+import org.junit.jupiter.params.ParameterizedTest;
+import org.junit.jupiter.params.provider.Arguments;
+import org.junit.jupiter.params.provider.MethodSource;
import org.apache.uniffle.common.config.RssBaseConf;
import org.apache.uniffle.common.rpc.ServerType;
-import static org.junit.jupiter.api.Assertions.assertThrows;
-
public class ShuffleManagerServerFactoryTest {
- @Test
- public void testShuffleManagerServerType() {
+ private static Stream<Arguments> shuffleManagerServerTypeProvider() {
+ return Stream.of(Arguments.of(ServerType.GRPC_NETTY),
Arguments.of(ServerType.GRPC));
Review Comment:
I liked the `ServerType.values()` that you had earlier, because this
automatically tests all types if more are added:
```suggestion
return Arrays.stream(ServerType.values());
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
