EnricoMi commented on code in PR #1663:
URL:
https://github.com/apache/incubator-uniffle/pull/1663#discussion_r1574951783
##########
client-spark/common/src/main/java/org/apache/uniffle/shuffle/manager/ShuffleManagerServerFactory.java:
##########
@@ -43,7 +43,7 @@ public GrpcServer getServer() {
public GrpcServer getServer(ShuffleManagerGrpcService service) {
ServerType type = conf.get(RssBaseConf.RPC_SERVER_TYPE);
- if (type == ServerType.GRPC) {
+ if (type == ServerType.GRPC || type == ServerType.GRPC_NETTY) {
Review Comment:
This does not look like fixing flaky tests but like a feature + testing it.
Maybe the PR title should be rephrased.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
