rickyma commented on code in PR #1663:
URL:
https://github.com/apache/incubator-uniffle/pull/1663#discussion_r1571877519
##########
client/src/main/java/org/apache/uniffle/client/impl/ShuffleReadClientImpl.java:
##########
@@ -102,12 +102,13 @@ public
ShuffleReadClientImpl(ShuffleClientFactory.ReadClientBuilder builder) {
readBufferSize = Integer.MAX_VALUE;
}
boolean offHeapEnabled =
builder.getRssConf().get(RssClientConf.OFF_HEAP_MEMORY_ENABLE);
-
builder.indexReadLimit(indexReadLimit);
builder.storageType(storageType);
builder.readBufferSize(readBufferSize);
builder.offHeapEnable(offHeapEnabled);
-
builder.clientType(builder.getRssConf().get(RssClientConf.RSS_CLIENT_TYPE));
+ if (builder.getClientType() == null) {
+
builder.clientType(builder.getRssConf().get(RssClientConf.RSS_CLIENT_TYPE));
Review Comment:
And that is the reason why
https://github.com/apache/incubator-uniffle/pull/1663/files#diff-2c63c456bb33c64e05cbb946b316f6b26ac9153fc8ef112024e47bf8c3fc3c5aR46
does not fail when we set `rss.client.type` to `GRPC_NETTY`. Because when
calling the builder's build() method, the client type will be reset to the
default value `GRPC` through RssConf, so there has actually been a hidden bug
here all along.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
