rickyma commented on code in PR #1738:
URL:
https://github.com/apache/incubator-uniffle/pull/1738#discussion_r1626885596
##########
internal-client/src/main/java/org/apache/uniffle/client/impl/grpc/ShuffleServerGrpcClient.java:
##########
@@ -381,28 +384,29 @@ public RssUnregisterShuffleByAppIdResponse
unregisterShuffleByAppId(
default:
String msg =
String.format(
- "Errors on unregister app to %s:%s for appId[%s], error: %s",
- host, port, request.getAppId(), rpcResponse.getRetMsg());
+ "Errors on unregister app to %s:%s for appId[%s] and
timeout[%ss], error: %s",
Review Comment:
unregistering will be better.
##########
internal-client/src/main/java/org/apache/uniffle/client/impl/grpc/ShuffleServerGrpcClient.java:
##########
@@ -414,8 +418,13 @@ public RssUnregisterShuffleResponse
unregisterShuffle(RssUnregisterShuffleReques
default:
String msg =
String.format(
- "Errors on unregister shuffle to %s:%s for
appId[%s].shuffleId[%], error: %s",
- host, port, request.getAppId(), request.getShuffleId(),
rpcResponse.getRetMsg());
+ "Errors on unregister shuffle to %s:%s for
appId[%s].shuffleId[%s] and timeout[%ss], error: %s",
Review Comment:
ditto
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
