EnricoMi commented on code in PR #1738:
URL:
https://github.com/apache/incubator-uniffle/pull/1738#discussion_r1626962507
##########
client-spark/common/src/main/java/org/apache/spark/shuffle/RssSparkConfig.java:
##########
@@ -191,8 +191,20 @@ public class RssSparkConfig {
createIntegerBuilder(new
ConfigBuilder("spark.rss.client.unregister.thread.pool.size"))
.createWithDefault(10);
+ public static final ConfigEntry<Integer> RSS_CLIENT_UNREGISTER_TIMEOUT_SEC =
+ createIntegerBuilder(
+ new ConfigBuilder("spark.rss.client.unregister.timeout.sec")
+ .doc(
+ "Unregister requests are executed concurrently and all
requests together "
+ + "have to complete within this timeout."))
+ .createWithDefault(60);
Review Comment:
This default effectively changes current behaviour waiting for all requests
from 10s to 60s. Should we leave the default at 10s? Is having a 1 minute
graceful shutdown reasonable for everyone? There will be a warning if this
timeout occurs:
Timeout occurred while unregistering from {}. Please consider increasing
the thread pool size (10) or the overall timeout (10s) if you still think the
request timeout (10s) is sensible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
