EnricoMi commented on code in PR #1738:
URL:
https://github.com/apache/incubator-uniffle/pull/1738#discussion_r1627352812
##########
client/src/main/java/org/apache/uniffle/client/impl/ShuffleWriteClientImpl.java:
##########
@@ -984,11 +995,25 @@ public void unregisterShuffle(String appId, int
shuffleId) {
ShuffleServerClientFactory.getInstance()
.getShuffleServerClient(clientType, shuffleServerInfo,
rssConf);
RssUnregisterShuffleResponse response =
client.unregisterShuffle(request);
- if (response.getStatusCode() != StatusCode.SUCCESS) {
- LOG.warn("Failed to unregister shuffle to " +
shuffleServerInfo);
+ if (response.getStatusCode() == StatusCode.SUCCESS) {
+ LOG.info("Successfully unregistered shuffle from {}",
shuffleServerInfo);
+ } else {
+ LOG.warn("Failed to unregister shuffle from {}",
shuffleServerInfo);
}
} catch (Exception e) {
- LOG.warn("Error happened when unregistering to " +
shuffleServerInfo, e);
+ if (e.getCause() != null && e.getCause() instanceof
InterruptedException) {
+ // InterruptedException indicates timeout, give some advice
Review Comment:
This `InterruptdException` is caused by `ExecutorService.invokeAll`
interrupting all threads on (general) timeout. Further, from the `Future` point
of view, I would not be able to easily access the `shuffleServerInfo` to
generate this error message for the interrupted request.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
