maobaolong commented on code in PR #1852:
URL:
https://github.com/apache/incubator-uniffle/pull/1852#discussion_r1662482550
##########
dashboard/src/main/java/org/apache/uniffle/dashboard/web/proxy/WebProxyServlet.java:
##########
@@ -45,7 +45,8 @@ protected String rewriteTarget(HttpServletRequest
clientRequest) {
String targetAddress =
coordinatorServerAddressesMap.get(clientRequest.getHeader("targetAddress"));
if (targetAddress == null) {
- return null;
+ // Get random one from coordinatorServerAddressesMap
+ targetAddress = coordinatorServerAddressesMap.values().iterator().next();
Review Comment:
In fact, it cannot be empty, because it must shutdown during the Process
startup stage if without any coordinator server address specified.
But, to be strict, I add a npe checker here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
