xianjingfeng commented on code in PR #1852:
URL:
https://github.com/apache/incubator-uniffle/pull/1852#discussion_r1671743056
##########
dashboard/src/main/java/org/apache/uniffle/dashboard/web/proxy/WebProxyServlet.java:
##########
@@ -44,6 +47,14 @@ protected String rewriteTarget(HttpServletRequest
clientRequest) {
}
String targetAddress =
coordinatorServerAddressesMap.get(clientRequest.getHeader("targetAddress"));
+ if (targetAddress == null) {
+ // Get random one from coordinatorServerAddressesMap
+ if (coordinatorServerAddressesMap.isEmpty()) {
+ LOG.error("No coordinator server address found.");
+ return null;
+ }
Review Comment:
```suggestion
```
These lines of code are no longer needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
