rickyma commented on code in PR #1852:
URL:
https://github.com/apache/incubator-uniffle/pull/1852#discussion_r1663573467
##########
dashboard/src/main/java/org/apache/uniffle/dashboard/web/utils/DashboardUtils.java:
##########
@@ -30,6 +31,7 @@ public class DashboardUtils {
private static final Logger LOG =
LoggerFactory.getLogger(DashboardUtils.class);
public static Map<String, String> convertAddressesStrToMap(String
coordinatorAddressesStr) {
+ Preconditions.checkNotNull(coordinatorAddressesStr);
Review Comment:
Could we also add some log here? Like what you did:
```
Preconditions.checkNotNull(coordinatorWebAddress, "Coordinator web address
is null");
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
