xianjingfeng commented on code in PR #1931:
URL:
https://github.com/apache/incubator-uniffle/pull/1931#discussion_r1704857744
##########
server/src/main/java/org/apache/uniffle/server/buffer/ShuffleBufferWithSkipList.java:
##########
@@ -111,8 +111,26 @@ public int getBlockCount() {
}
@Override
- public void release() {
- blocksMap.values().forEach(spb -> spb.getData().release());
+ public long release() {
Review Comment:
I think we need to add `synchronized` here. Calling the `toFlushEvent`
method and the `release` method at the same time may result in duplicate
release.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
