maobaolong commented on code in PR #1931:
URL:
https://github.com/apache/incubator-uniffle/pull/1931#discussion_r1723095518
##########
server/src/main/java/org/apache/uniffle/server/buffer/ShuffleBufferWithLinkedList.java:
##########
@@ -110,8 +110,26 @@ public int getBlockCount() {
}
@Override
- public void release() {
- blocks.forEach(spb -> spb.getData().release());
+ public long release() {
+ Throwable lastException = null;
+ int failedReleaseSize = 0;
+ long releaseSize = 0;
+ for (ShufflePartitionedBlock spb : blocks) {
+ try {
+ spb.getData().release();
+ releaseSize += spb.getSize();
+ } catch (Throwable t) {
+ lastException = t;
+ failedReleaseSize += spb.getSize();
+ }
+ }
+ if (lastException != null) {
+ LOG.warn(
+ "Failed to release shuffle blocks with size {}. Maybe it released by
others",
Review Comment:
done
##########
server/src/main/java/org/apache/uniffle/server/buffer/ShuffleBufferWithSkipList.java:
##########
@@ -111,8 +111,26 @@ public int getBlockCount() {
}
@Override
- public void release() {
- blocksMap.values().forEach(spb -> spb.getData().release());
+ public long release() {
+ Throwable lastException = null;
+ int failedReleaseSize = 0;
+ long releaseSize = 0;
+ for (ShufflePartitionedBlock spb : blocksMap.values()) {
+ try {
+ spb.getData().release();
+ releaseSize += spb.getSize();
+ } catch (Throwable t) {
+ lastException = t;
+ failedReleaseSize += spb.getSize();
+ }
+ }
+ if (lastException != null) {
+ LOG.warn(
+ "Failed to release shuffle blocks with size (). Maybe it released by
others",
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
