lwllvyb commented on code in PR #1931:
URL:
https://github.com/apache/incubator-uniffle/pull/1931#discussion_r1705472070
##########
server/src/main/java/org/apache/uniffle/server/buffer/ShuffleBufferWithSkipList.java:
##########
@@ -111,8 +111,26 @@ public int getBlockCount() {
}
@Override
- public void release() {
- blocksMap.values().forEach(spb -> spb.getData().release());
+ public long release() {
Review Comment:
> Thread-1( toFlushEvent): List spBlocks = new LinkedList<>(blocks);
**toFlushEvent** will be guarded by app read lock.
> Thread-2(release): blocks.forEach(spb -> spb.getData().release()); (The
first release)
The **release** function be called in **removeResources** or
**removeResourcesByShuffleIds**, guarded by app write lock.
So this situation cannot happen. I don't know if my decription is corret.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
