rickyma commented on code in PR #1931:
URL:
https://github.com/apache/incubator-uniffle/pull/1931#discussion_r1723189775
##########
server/src/main/java/org/apache/uniffle/server/buffer/ShuffleBufferManager.java:
##########
@@ -715,9 +715,18 @@ public void removeBufferByShuffleId(String appId,
Collection<Integer> shuffleIds
Collection<ShuffleBuffer> buffers =
bufferRangeMap.asMapOfRanges().values();
if (buffers != null) {
for (ShuffleBuffer buffer : buffers) {
- buffer.release();
+ // the actual release size by this thread
+ long releaseSize = buffer.release();
Review Comment:
releasedSize
##########
server/src/main/java/org/apache/uniffle/server/buffer/ShuffleBufferWithSkipList.java:
##########
@@ -111,8 +111,26 @@ public int getBlockCount() {
}
@Override
- public void release() {
- blocksMap.values().forEach(spb -> spb.getData().release());
+ public long release() {
+ Throwable lastException = null;
+ int failedReleaseSize = 0;
+ long releaseSize = 0;
Review Comment:
ditto
##########
server/src/main/java/org/apache/uniffle/server/buffer/ShuffleBufferWithSkipList.java:
##########
@@ -111,8 +111,26 @@ public int getBlockCount() {
}
@Override
- public void release() {
- blocksMap.values().forEach(spb -> spb.getData().release());
+ public long release() {
+ Throwable lastException = null;
+ int failedReleaseSize = 0;
Review Comment:
ditto
##########
server/src/main/java/org/apache/uniffle/server/buffer/ShuffleBufferManager.java:
##########
@@ -715,9 +715,18 @@ public void removeBufferByShuffleId(String appId,
Collection<Integer> shuffleIds
Collection<ShuffleBuffer> buffers =
bufferRangeMap.asMapOfRanges().values();
if (buffers != null) {
for (ShuffleBuffer buffer : buffers) {
- buffer.release();
+ // the actual release size by this thread
Review Comment:
released
##########
server/src/main/java/org/apache/uniffle/server/buffer/ShuffleBufferWithLinkedList.java:
##########
@@ -110,8 +110,26 @@ public int getBlockCount() {
}
@Override
- public void release() {
- blocks.forEach(spb -> spb.getData().release());
+ public long release() {
+ Throwable lastException = null;
+ int failedReleaseSize = 0;
+ long releaseSize = 0;
Review Comment:
releasedSize
##########
server/src/main/java/org/apache/uniffle/server/buffer/ShuffleBufferWithLinkedList.java:
##########
@@ -110,8 +110,26 @@ public int getBlockCount() {
}
@Override
- public void release() {
- blocks.forEach(spb -> spb.getData().release());
+ public long release() {
+ Throwable lastException = null;
+ int failedReleaseSize = 0;
Review Comment:
failedToReleaseSize
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
