rickyma commented on code in PR #2098:
URL:
https://github.com/apache/incubator-uniffle/pull/2098#discussion_r1741930677
##########
internal-client/src/main/java/org/apache/uniffle/client/impl/grpc/GrpcClient.java:
##########
@@ -76,9 +77,13 @@ protected GrpcClient(ManagedChannel channel) {
this.channel = channel;
}
- protected ByteBufAllocator createByteBufAllocator(
+ private static synchronized ByteBufAllocator getByteBufAllocator(
Review Comment:
To unify the structure and naming in this project as a whole, add a method
called `getSharedPooledByteBufAllocator` into `GrpcNettyUtils` refer to
https://github.com/apache/incubator-uniffle/pull/1803.
I think it's better to put the logic there.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
