rickyma commented on code in PR #2098:
URL:
https://github.com/apache/incubator-uniffle/pull/2098#discussion_r1743981904
##########
internal-client/src/main/java/org/apache/uniffle/client/impl/grpc/GrpcClient.java:
##########
@@ -76,9 +77,13 @@ protected GrpcClient(ManagedChannel channel) {
this.channel = channel;
}
- protected ByteBufAllocator createByteBufAllocator(
+ private static synchronized ByteBufAllocator getByteBufAllocator(
Review Comment:
I prefer to use `rss.client.netty.client.shared.allocator.enabled` to
control whether to use a shared Netty allocator for gRPC as well. It's like
what Spark does. Spark set `shared.allocator.enabled` to `true` **_always_**.
In this case, we can unify the code in the project.
But I'm also okay with not using
`rss.client.netty.client.shared.allocator.enabled` for gRPC. Because gRPC will
be deprecated in the future in Uniffle, so I'm open to whatever happens to gRPC
related codes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
