zhengchenyu commented on code in PR #2098:
URL:
https://github.com/apache/incubator-uniffle/pull/2098#discussion_r1745036767
##########
internal-client/src/main/java/org/apache/uniffle/client/impl/grpc/GrpcClient.java:
##########
@@ -76,9 +77,13 @@ protected GrpcClient(ManagedChannel channel) {
this.channel = channel;
}
- protected ByteBufAllocator createByteBufAllocator(
+ private static synchronized ByteBufAllocator getByteBufAllocator(
Review Comment:
In fact, if we use rss.client.netty.client.shared.allocator.enabled, we have
to pass the conf extra. It wastes memory by not sharing allocator. Even if we
add this conf here, it will always be set to true. So I do not use this config.
How about you?
##########
internal-client/src/main/java/org/apache/uniffle/client/impl/grpc/GrpcClient.java:
##########
@@ -76,9 +77,13 @@ protected GrpcClient(ManagedChannel channel) {
this.channel = channel;
}
- protected ByteBufAllocator createByteBufAllocator(
+ private static synchronized ByteBufAllocator getByteBufAllocator(
Review Comment:
In fact, if we use rss.client.netty.client.shared.allocator.enabled, we have
to pass the conf extra. It wastes memory by not sharing allocator. Even if we
add this conf here, it will always be set to true. So I do not use this config.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
