xianjingfeng commented on code in PR #2112:
URL:
https://github.com/apache/incubator-uniffle/pull/2112#discussion_r1766084474
##########
internal-client/src/main/java/org/apache/uniffle/client/factory/ShuffleServerClientFactory.java:
##########
@@ -75,9 +80,30 @@ public synchronized ShuffleServerClient
getShuffleServerClient(
return serverToClients.get(shuffleServerInfo);
}
+ public synchronized void cleanUselessShuffleServerClients(
Review Comment:
I think it is impossible, if another thread to hold the removing client, the
`shuffleServerInfo` of the removing client will always be in
`shuffleServerInfoMap`.
##########
internal-client/src/main/java/org/apache/uniffle/client/factory/ShuffleServerClientFactory.java:
##########
@@ -75,9 +80,30 @@ public synchronized ShuffleServerClient
getShuffleServerClient(
return serverToClients.get(shuffleServerInfo);
}
+ public synchronized void cleanUselessShuffleServerClients(
Review Comment:
I think it is impossible, if another thread hold the removing client, the
`shuffleServerInfo` of the removing client will always be in
`shuffleServerInfoMap`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
