zuston commented on code in PR #2112:
URL: https://github.com/apache/uniffle/pull/2112#discussion_r2038738301
##########
internal-client/src/main/java/org/apache/uniffle/client/factory/ShuffleServerClientFactory.java:
##########
@@ -75,9 +80,29 @@ public synchronized ShuffleServerClient
getShuffleServerClient(
return serverToClients.get(shuffleServerInfo);
}
+ public synchronized void closeClients(Set<ShuffleServerInfo> candidates) {
Review Comment:
From my thought, all clients are managed by the shuffleServerClientFactory,
if in this class, we could maintain a structure to record the every client
reference count num. if the client reference count is 0, then we could release
it.
If so, the +1 operation could be happened on the `getShuffleServerClient`.
And -1 should be happened on the removing in shuffleWriteClientImpl.
How about this way?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
