zuston commented on code in PR #2112:
URL: https://github.com/apache/uniffle/pull/2112#discussion_r2035340591
##########
internal-client/src/main/java/org/apache/uniffle/client/factory/ShuffleServerClientFactory.java:
##########
@@ -75,9 +80,30 @@ public synchronized ShuffleServerClient
getShuffleServerClient(
return serverToClients.get(shuffleServerInfo);
}
+ public synchronized void cleanUselessShuffleServerClients(
Review Comment:
This method impl is not straightforward, I hope the impl like the following
code:
```
public synchronized void closeClients(List<ShuffleServerInfo> candidates) {
// ....
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
