maobaolong commented on code in PR #2210:
URL:
https://github.com/apache/incubator-uniffle/pull/2210#discussion_r1807566408
##########
storage/src/main/java/org/apache/uniffle/storage/handler/impl/LocalFileWriter.java:
##########
@@ -33,10 +35,16 @@ public class LocalFileWriter implements FileWriter,
Closeable {
private FileOutputStream fileOutputStream;
private long nextOffset;
+ @VisibleForTesting
public LocalFileWriter(File file) throws IOException {
+ this(file, 8 * 1024);
+ }
+
+ public LocalFileWriter(File file, long bufferSize) throws IOException {
Review Comment:
Why you define long type but used as int type? I guess it is from the long
type configure item, so you can convert to int type earlier, it is better to
convert it after get value from config.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
