lwllvyb commented on code in PR #2210:
URL:
https://github.com/apache/incubator-uniffle/pull/2210#discussion_r1808045506
##########
storage/src/main/java/org/apache/uniffle/storage/handler/impl/LocalFileWriter.java:
##########
@@ -33,10 +35,16 @@ public class LocalFileWriter implements FileWriter,
Closeable {
private FileOutputStream fileOutputStream;
private long nextOffset;
+ @VisibleForTesting
public LocalFileWriter(File file) throws IOException {
+ this(file, 8 * 1024);
+ }
+
+ public LocalFileWriter(File file, long bufferSize) throws IOException {
Review Comment:
BufferedOutputStream's constructor need int type and getSizeAsBytes will
convert the string value to long type.
I will change the code to convert the value's type earlier.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
