jerqi commented on code in PR #2210:
URL:
https://github.com/apache/incubator-uniffle/pull/2210#discussion_r1808210819
##########
common/src/main/java/org/apache/uniffle/common/config/RssBaseConf.java:
##########
@@ -294,6 +294,18 @@ public class RssBaseConf extends RssConf {
+ " first combining the username and the password with a
colon (uniffle:uniffle123)"
+ ", and then by encoding the resulting string in base64
(dW5pZmZsZTp1bmlmZmxlMTIz).");
+ public static final ConfigOption<String> RSS_STORAGE_WRITE_DATA_BUFFER_SIZE =
+ ConfigOptions.key("rss.storage.write.data.buffer.size")
Review Comment:
The last segment prefer using Camel style like
`rss.storage.write.dataBufferSize`.
##########
common/src/main/java/org/apache/uniffle/common/config/RssBaseConf.java:
##########
@@ -294,6 +294,18 @@ public class RssBaseConf extends RssConf {
+ " first combining the username and the password with a
colon (uniffle:uniffle123)"
+ ", and then by encoding the resulting string in base64
(dW5pZmZsZTp1bmlmZmxlMTIz).");
+ public static final ConfigOption<String> RSS_STORAGE_WRITE_DATA_BUFFER_SIZE =
+ ConfigOptions.key("rss.storage.write.data.buffer.size")
+ .stringType()
+ .defaultValue("8k")
+ .withDescription("The buffer size to cache the write data content.");
+
+ public static final ConfigOption<String> RSS_STORAGE_WRITE_INDEX_BUFFER_SIZE
=
Review Comment:
ditto.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
