[
https://issues.apache.org/jira/browse/YUNIKORN-638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17331090#comment-17331090
]
Weiwei Yang commented on YUNIKORN-638:
--------------------------------------
Hi [~avsamit6600]
IMO, I think it's better to make this configurable via taskGroup definition:
taskGroup:
- name: xx
- minMember: xx
- placeholderDockerImage: xxx
this way, we provide the flexibility for people to overwrite the docker image
freely, and we can further leverage this for pre-downloading docker images for
the pods. E.g pre-download Spark docker image via placeholders. Will this be
helpful?
> Make placeholder image configurable
> -----------------------------------
>
> Key: YUNIKORN-638
> URL: https://issues.apache.org/jira/browse/YUNIKORN-638
> Project: Apache YuniKorn
> Issue Type: Sub-task
> Components: shim - kubernetes
> Reporter: Chaoran Yu
> Assignee: Amit Sharma
> Priority: Minor
>
> The placeholder image is currently hard-coded as a constant at
> https://github.com/apache/incubator-yunikorn-k8shim/blob/v0.10.0/pkg/common/constants/constants.go#L55.
> In many sectors and enterprises, it's common to have restricted internet
> access. When replacing the placeholder image with something else, the entire
> k8shim image also needs to be rebuilt. It's more inconvenient when different
> deployment environments (dev/test, staging and prod) can't access images in
> another environment.
> It would be better if the placeholder image can be configured in the Helm
> chart:
> https://github.com/apache/incubator-yunikorn-release/blob/master/helm-charts/yunikorn/values.yaml.
> That would make CI/CD easier too
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
