On Tue, Nov 12, 2013 at 4:40 AM, Oswald Buddenhagen <[email protected]> wrote: > On Mon, Nov 11, 2013 at 07:05:04AM -0600, Felipe Contreras wrote: >> Oswald Buddenhagen wrote: >> > this is now done in the maxmessages branch. >> > the option is called ExpireUnread yes/no > >> you start from the assumption that people would automatically assume >> unread messages are not included in this limit, and I think it would >> be the opposite for most people. >> > well, there are two considerations: > - i didn't want to change the default behavior > - i wanted to default to the safe (don't miss messages) option. though > it can be argued that this default is unsafe as far as the size of the > initial fetch goes. so maybe i should just make it error out if > MaxMessages is exceeded by more than 50% and no explicit setting is > present.
That is orthogonal; the default of ExemptUnread can be 'yes'. >> I think LimitExcemptUnread is much clearer because a) it explains what the >> option affects; limits (which could be MaxAge, MaxMessages, etc.), b) the >> word >> except makes it clear that the limit rule doesn't apply to this kind of >> messages. >> > you meant "exempt". ;) > while "limit" may associate better with the "max*" options, it's not > self-explanatory either. so given that one needs to look into the man > page anyway and the related options are right next to each other, i > don't think it's much of a consideration. > also, "LimitExemptUnread" is just awkward. it's bad grammar, and sounds > plain awful. ExemptUnread then. > while "expire" is moderately inaccurate in case of count-limiting, it > associates well with the notion that messages spend some time in the > local mailbox and then go poof (for whatever reason). therefore i find > it reasonably intuitive. Well I don't. It's very clear that ExemptUnread applies to some kind of rule, and the only one that fits is MaxMessage. Whereas ExpireUnread doen't imply any rule or anything at all that relates it to MaxMessages. > anyway, we are now really in the realm of bikeshedding ... Not entirely sure. In true bike-shedding the color of the bike-shed doesn't matter, could be rd, could be blue, you just have to pick. But if this is truly bikeshedding the name of the variable doesn't matter, so it doesn't matter to you, lets just pick ExemptUnread and be done with it :) I presume you think the name does matter, and therefore it's not bike-shedding. > i'll try to allocate time for fixing the remaining issues over the > weekend. Sure, that's more important, but I think it makes sense to wait for feedback from other people about the name of the option before merging to master. Cheers. -- Felipe Contreras ------------------------------------------------------------------------------ November Webinars for C, C++, Fortran Developers Accelerate application performance with scalable programming models. Explore techniques for threading, error checking, porting, and tuning. Get the most from the latest Intel processors and coprocessors. See abstracts and register http://pubads.g.doubleclick.net/gampad/clk?id=60136231&iu=/4140/ostg.clktrk _______________________________________________ isync-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/isync-devel
