Morten,

2011/5/17 Morten Omholt Alver <mortenal...@gmail.com>:
> Perhaps
> we could translate the default names of the tabs, but if we translate
> whatever name the tab has at any time, it could be a little confusing
> for the user.

I see. So, if a user makes up a customized tab "Accept", it hits the
keyword "Accept" in the properties file and automatically translated
into local language.

It means we need handle default tabs separately from other possible
tabs and make sure that only default tabs are translated. One solution
may be to attach "reserved words" to those keywords "General",
"Abstract" and "Review" to distinguish from any possible words, and
translate only those words. Of course, it bans all users to use the
reserved words. As a candidate, I chose to add "[[CUSTOM_TAB]]" to
those keywords which is unlikely to become necessary for users.

The call of Globals.lang() is made for only those default words as
shown below (I attach a patch as well for all changes including those
in .properties files):

diff -ur jabref.orig/src/java/net/sf/jabref/EntryEditor.java
jabref/src/java/net/sf/jabref/EntryEditor.java
--- jabref.orig/src/java/net/sf/jabref/EntryEditor.java 2011-05-16
00:06:52.000000000 +0900
+++ jabref/src/java/net/sf/jabref/EntryEditor.java      2011-05-17
21:00:42.000000000 +0900
@@ -276,7 +276,12 @@
         for (int i = 0; i < tabList.getTabCount(); i++) {
             EntryEditorTab newTab = new EntryEditorTab(frame, panel,
tabList.getTabFields(i), this, false,
                 tabList.getTabName(i));
-            tabbed.addTab(Globals.lang(tabList.getTabName(i)),
GUIGlobals.getImage("general"), newTab.getPane());
+                       String tabName = tabList.getTabName(i);
+                       if (tabName == "General[[CUSTOM_TAB]]" ||
tabName == "Abstract[[CUSTOM_TAB]]"
+                               || tabName == "Review[[CUSTOM_TAB]]") {
+                               tabName = Globals.lang(tabName);
+                       }
+            tabbed.addTab(tabName, GUIGlobals.getImage("general"),
newTab.getPane());
             tabs.add(newTab);
         }

Does this work?


> Morten
>

Best regards,

Koji

Attachment: optionTab.patch
Description: Binary data

------------------------------------------------------------------------------
Achieve unprecedented app performance and reliability
What every C/C++ and Fortran developer should know.
Learn how Intel has extended the reach of its next-generation tools
to help boost performance applications - inlcuding clusters.
http://p.sf.net/sfu/intel-dev2devmay
_______________________________________________
Jabref-devel mailing list
Jabref-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/jabref-devel

Reply via email to