On 2017-08-31 02:15, Otavio Pontes wrote:
> Use length defined by PCI specification for AER (Advanced Error
> Reporting) capability. This is relevant if PCI device is assigned for an
> inmate cell and this capability is accessed.
>
> Capability is set as RW, because there are relevant fields that are
> read-write.
That is not enough to argue that write access is safe. Did you check
that AER will only have impact on the individual function (in a
multi-function device)? If we can answer this with "yes" based on the
PCI specs, we can enable write permission for all devices. Otherwise, I
would leave this read-only and let the user decide on case-by-case.
Jan
> ---
> tools/jailhouse-config-create | 12 ++++++++++++
> 1 file changed, 12 insertions(+)
>
> diff --git a/tools/jailhouse-config-create b/tools/jailhouse-config-create
> index ce2affc..7fd37ab 100755
> --- a/tools/jailhouse-config-create
> +++ b/tools/jailhouse-config-create
> @@ -226,6 +226,7 @@ class PCICapability:
> def parse_pcicaps(dir):
> caps = []
> has_extended_caps = False
> + tlp_prefix_supported = False
> f = input_open(os.path.join(dir, 'config'), 'rb')
> f.seek(0x06)
> (status,) = struct.unpack('<H', f.read(2))
> @@ -259,6 +260,11 @@ class PCICapability:
> (cap_reg,) = struct.unpack('<H', f.read(2))
> if (cap_reg & 0xf) >= 2: # v2 capability
> len = 60
> + f.seek(cap + 0x24)
> + (dev_cap2,) = struct.unpack('<xB', f.read(2))
> + if dev_cap2 & 0x20 != 0:
> + tlp_prefix_supported = True
> +
> # access side effects still need to be analyzed
> flags = PCICapability.RD
> has_extended_caps = True
> @@ -297,6 +303,12 @@ class PCICapability:
> len = 64
> # access side effects still need to be analyzed
> flags = PCICapability.RD
> + elif id == 0x0001: # AER
> + if tlp_prefix_supported:
> + len = 0x48
> + else:
> + len = 0x38
> + flags = PCICapability.RW
> else:
> if (id & PCICapability.JAILHOUSE_PCI_EXT_CAP) != 0:
> print('WARNING: Ignoring unsupported PCI Express '
>
--
Siemens AG, Corporate Technology, CT RDA ITP SES-DE
Corporate Competence Center Embedded Linux
--
You received this message because you are subscribed to the Google Groups
"Jailhouse" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
