On 07.05.19 23:14, Hakkı Kurumahmut wrote:
@Jan
I have a question about the patch. assign_iommu_info and append_comment_info
methods is running for PCI-PCI bridge primary and secondary bus,dev,fn.
I'm not sure it should work for the primary bus,dev,fn.
Example Device Scope:
01 0A 00 00 00 00 1C 07 00 00
01 0A 00 00 00 00 1C 07 00 02
01 0A 00 00 00 00 1C 07 00 04
It is running order
1.) 00:1C.07
2.) sec-bus:00.00
3.) 00:1C.07
4.) sec-bus:00.02
5.) 00:1C.07
6.) sec-bus:00.04
May be it is run for only secondary buses.
1.) sec-bus:00.00
2.) sec-bus:00.02
3.) sec-bus:00.04
I'm not yet sure I get the idea of your patch. Unfortunately, it mixes a
refactoring with the enhancement of device scope parser. Why?
I would have added this feature by simply enhancing parse_dmar_devscope. That
function is just missing the hierarchy walk when a more complex scope is
provided, basically what is described in the spec, section 8.3.1, in pseudocode.
Then parse_dmar_devscope would continue to provide us (bus, dev, fn) as output,
and no further changes to the rest would be needed.
Jan
--
You received this message because you are subscribed to the Google Groups
"Jailhouse" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/jailhouse-dev/ab15444f-4a35-712f-3979-8b04a395ee1e%40web.de.
For more options, visit https://groups.google.com/d/optout.
