Morgan,
Still I would have preferred to have the approval of existing committers
rather than just intruding ... :-) Also, I would like to know the plan
regarding the releases. Can I touch the main branch ? When are we suppose to
release anything ? Or should I use the rlwrefactoring branch ?
Regarding coding conventions, I almost agree with you expect on the
following points :
* When I commit some code, I like to follow the existing coding conventions
so that it is easier to read and understand the code. You can usually do
this by following the existing conventions. However, by looking at the file
I have found several conflicting conventions so I am not sure which to use
* For debugging, it is very important to have conventions like the one I
have proposed otherwise it makes reading log files very hard or impossible
(like logging entry/exits of methods, ...)
* I don't really care if the coding conventions reflect my style or not,
they just need to be there. I don't want to start a religious war on coding
conventions either ... :)
* I do *really* care if you use tabs instead of spaces because it makes the
code undreadable and is really annoying.
* I do care to show something homogeinez for other uses that will use this
framework. We are developing components that are going to be used on other
projects. Users are very likely to look at the source code and I prefer to
show something nicely documented with consistent coding conventions rather
than the opposite.
* I have very good IDEs (and even Ant task) that does the reformatting so it
won't take long to reformat once we agree on a convention.
* I have made a proposition based on the current code. Just give your +1 and
it's done ... :-) (or change it)
Thanks
-Vincent
----- Original Message -----
From: "Morgan Delagrange" <[EMAIL PROTECTED]>
To: <[EMAIL PROTECTED]>; <[EMAIL PROTECTED]>
Sent: Monday, August 27, 2001 3:00 PM
Subject: Re: [httpclient] new committer
Hi Vincent,
You don't need to ask for permission to be a committer. Because you are
already a member of the Commons subproject, you simply need to add your name
to the STATUS.html file when you are ready to perform a commit.
As for your suggestions, some of them I like, some of them I'm not so crazy
about. In particular, I'd rather not spark an undoubtedly protracted
discussion of coding conventions. We all have our own style, and at the end
of the day it doesn't matter much if you indent with two spaces or four.
- Morgan
Vincent Massol wrote on 8/25/01 9:16 am:
>Hi,
>
>I'd like to propose myself as
>a committer for the
>httpclient component. I woud
>like to use it for Cactus and I
>have actually started to use
>it already.
>
>Here are the few things that
>I'd like to work on if I am
>admitted :
>
>* provide an implementation
>of HttpURLConnection that is
>a wrapper around Http Client
>classes (a first version that I
>test on Cactus is almost
>finished),
>* correct the multiple
>header bug (if we agree it is
>a bug but I think it is one as
>the Servlet Engine I test with,
>Resin, sends back multiple
>set-cookie headers and the
>spec says it is allowed),
>* set up some web pages for
>HttpClient and especially :
> - a page defining the coding
>conventions for Http Client
>(BTW, do we want one
>standard for all jakarta-
>commons components.
>Maybe hard to get a
>consensus?). It will also
>explain logging conventions
>in order to have something
>consistent in the code
>* correct all classe file
>licenses so that it says
>"Commons" and "HttpClient"
>instead of "Tomcat",
>* improve some java doc
>that I know had some
>difficulties understanding at
>first
>* help normalize the code
>with the coding conventions
>we will have defined change
>logging logic so that when no
>httpclient.log property is
>defined and Log4j is on the
>classpath it uses the
>Log4JCategoryLog by
>default
>
>That will be enough for a
>start :)
>
>How is that ?
>Thanks
>-Vincent
>
>
_________________________________________________________
Do You Yahoo!?
Get your free @yahoo.com address at http://mail.yahoo.com
