Hi, All my proposals were kind of a joke, except maybe the last one involving William. I 100% understand what you say. In this case, the "Description" field problem wasn't hard to fix, and wasn't about code itself (but previous commit contained hard-coded pin declarations). But it's not a matter of being JSG compliant at the end, it's about being involved and "daring to put your head over the lawn field" (Dutch expression IIRC).
Making him commiting to "casualities" directory seems a good idea to me. Eur now needs to read this... Cheers, Seb 2010/4/9 vasile surducan <[email protected]> > > > On Fri, Apr 9, 2010 at 8:34 AM, Rob Hamerling <[email protected]>wrote: > >> >> Hi Seb, >> >> >> On 04/09/10 10:22 am, Sebastien Lelong wrote: >> >>> >>> Buildbot failed again due to last Eur's commit. So far no reply from >>> Eur. It already happened before, and I did moved his libs & samples in >>> "casualities". >>> >>> I can see three different options in order to fix this in the long term: >>> >>> - removing commit permission to Eur, so next time he'll show here and >>> ask why he can't commit. We may explain then he has to check buildbot >>> results (or even better, his code before committing) after a commit. (he >>> actually knows this, as he was a big fan of buildbot at the first it was >>> setup) >>> >>> - setup a buildbot dedicated to Eur, which detects his commits and >>> automatically move his files to "casualities" >>> >>> - pick someone here who will fix the code. This can be done through >>> round robin, randomly, or better, William can handle this. William, >>> AFAIK, since Eur is your sponsor, as mentioned in libraries and samples >>> you commit, would you also fix Eur's code ? >>> >> >> Difficult to compare the pro's and con's! >> One thing we shouldn't do is making exceptions for one or more specific >> persons. In earlier discussions I've indicated that I think it is not >> respectful to let 'dirty' code (in the sense of violating the JSG) be fixed >> by someone else. So I must vote for number one, but I regret that this is >> needed. >> >> > Hi Rob, Seb, > > Eur's code is very useful even is more straight forward dedicated to > applications, without the beauty of a library (in the sense of jallib). I > think the value of such tested work is bigger than the pain of complaining > about non-standards. Maybe non of the solutions above, but asking Eur to > commit his non-standard files directly on the casualities folder. The > probability of dealing with a busy man which is living writing his code and > don't follow the email topics is also appreciable. Please do not rush with > any decisions which can do more damage than good things. > > my two cents, > Vasile > > -- > You received this message because you are subscribed to the Google Groups > "jallib" group. > To post to this group, send email to [email protected]. > To unsubscribe from this group, send email to > [email protected]<jallib%[email protected]> > . > For more options, visit this group at > http://groups.google.com/group/jallib?hl=en. > -- Sébastien Lelong http://www.sirloon.net http://sirbot.org -- You received this message because you are subscribed to the Google Groups "jallib" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/jallib?hl=en.
