Hi guys, I don't particular want to delete these samples. I suggest to remove samples that have the risk of getting outdated. There are about 10 board files, so each test file delivers up to 10 samples. Once an issues is resolved or the test file is extended, all the samples are regenerated.If a sample fails to regenerate, it remains behind and no-one notices. IMO this is an undesirable situation.
On the other hand, there is a reason for a sample generation to fail. The two particular samples at hand are special in the way that only one of the 10 board files has supplied a sample and currently, none is. Maybe the sample requires something specific in the board file. If this requirement is removed, you'll probably have half a dozen samples for this library. We had a discussion on samples before and it turns out that everyone has its own approach. This is quite inefficient but I don't think this is likely to change. And since I am the only one that use the jallib.py sample generation function, I feel it is my responsibility to keep that part up to date. I did most of the cleanup about a year ago and AFAIK this is the last remaining issue. IMO it would be wise to have separate directories at jallib for (at least) the samples Rob generates, the samples from jallib.py and the rest, which are mainly manually maintained. If Matt regenerates his samples, it should have its own directory too. I'm not sure what the impact on the generation processes would be. I also considered abandoning the sample generation, since it generates many similar files and the original intention, to run each test on each device for each release, has long been abandoned. For testing, I don't use the sample generation either. I just create a small file that includes the board file and the test file. Work like a charm. I wonder how use full over 1000 samples in one directory are for an average user and if either reduction of the number of samples or some structure would be helpful (e.g. separate directories for samples generated by method and one for the manual maintained ones). Joep 2012/4/22 Sebastien Lelong <[email protected]>: > Hi Joep, > > Well, that was kind of a joke :) but still, I don't understand, as Rob, why > you want to delete these samples. I made these ones not generated anymore, > because they are needed in the distribution (at least for GP2D02 lib since > sample is unique). > > Cheers, > Seb > > > 2012/4/22 Joep Suijs <[email protected]> >> >> Hi, >> >> So I understand these samples are relevant and since there is no >> reference to generation, they are here to stay. >> Does this also mean you agree with my intention to remove samples when >> they are no longer generated? >> (Of course, before doing so, it might be wise to check what causes the >> samples not to be valid any more). >> >> Joep >> >> >> 2012/4/22 <[email protected]>: >> > Revision: 3044 >> > Author: sebastien.lelong >> > Date: Sun Apr 22 13:25:19 2012 >> > Log: save samples from apocalypse >> > http://code.google.com/p/jallib/source/detail?r=3044 >> > >> > Modified: >> > /trunk/sample/16f88_ir_ranger_gp2d02.jal >> > /trunk/sample/16f88_pwm_led.jal >> > >> > -- >> > You received this message because you are subscribed to the Google >> > Groups >> > "jallib" group. >> > To post to this group, send email to [email protected]. >> > To unsubscribe from this group, send email to >> > [email protected]. >> > For more options, visit this group at >> > http://groups.google.com/group/jallib?hl=en. >> > >> >> -- >> You received this message because you are subscribed to the Google Groups >> "jallib" group. >> To post to this group, send email to [email protected]. >> To unsubscribe from this group, send email to >> [email protected]. >> For more options, visit this group at >> http://groups.google.com/group/jallib?hl=en. >> > > > > -- > Sébastien Lelong > > > -- > You received this message because you are subscribed to the Google Groups > "jallib" group. > To post to this group, send email to [email protected]. > To unsubscribe from this group, send email to > [email protected]. > For more options, visit this group at > http://groups.google.com/group/jallib?hl=en. -- You received this message because you are subscribed to the Google Groups "jallib" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/jallib?hl=en.
