Hi David,
I would always (wherever possible) want to reproduce any problem before applying a fix. That way you can find out the root cause (which may need a different fix), and ideally add unit tests to expose the problem and verify the fix. I'll check with Jim to see if he can suggest a route to cause this error, if not maybe close as not reproducible. Are you able to commit updates to Messages_es.properties to match the latest code changes? e.g. label.new_sequence_fetcher etc You said you were waiting for something from Ipek? What is Ipek? Thanks, Mungo ________________________________ From: [email protected] <[email protected]> on behalf of David Roldán Martínez <[email protected]> Sent: 29 September 2014 16:25 To: Jalview Development List Subject: Re: [Jalview-dev] Jal-1420 ups. then I suggest to close the ticket as non reproducible or apply the original patch that prevents for potential NPE. What do you think about that? El 29/09/2014 14:44, "Mungo Carstairs" <[email protected]<mailto:[email protected]>> escribió: Nope, no error for me with that file and steps either. It looks as though UserDefinedColours.resetButtonPanel() should populate the upperCaseButtons Vector. I can't see how to break this! mungo On Mon, Sep 29, 2014 at 1:06 PM, David Roldán Martínez <[email protected]<mailto:[email protected]>> wrote: Mungo, These are the steps I've followed (see http://issues.jalview.org/browse/JAL-1420 comments). 1. Load an alignment (I'm attaching the clustal omega file) 2. Colour -> User defined... 3. Press OK/Apply button If the patch is not applied, you'll find an stacktrace similar to Exception in thread "AWT-EventQueue-2" java.lang.ArrayIndexOutOfBoundsException: 0 >= 0 at java.util.Vector.elementAt(Vector.java:470) at jalview.gui.UserDefinedColours.getSchemeFromButtons(UserDefinedColours.java:464) ..... If the patch is applied, a warning message is shown to the user until he/she makes a colour selection for the scheme (see Captura.PNG at the jira). I'm testing under Release_2_8_2_Branch. Cheers, David 2014-09-29 13:52 GMT+02:00 Mungo Carstairs <[email protected]<mailto:[email protected]>>: I'm not seeing any error in the console either. m On Mon, Sep 29, 2014 at 12:01 PM, David Roldán Martínez <[email protected]<mailto:[email protected]>> wrote: Hi Mungo, No apparent error at the gui but an exception appears at the console. Cheers, David El 29/09/2014 10:26, "Mungo Carstairs" <[email protected]<mailto:[email protected]>> escribió: Hello David, JAL-1420 - I'm not succeeding in reproducing the error before trying the patch. I seem to be able to apply / OK / save a colour scheme with no colours selected, without error. Any tips for reproducing the error? Thanks Mungo On Fri, Sep 26, 2014 at 7:53 PM, David Roldán Martínez <[email protected]<mailto:[email protected]>> wrote: ok. I'll try to take a look tomorrow. Thanks! El 26/09/2014 14:13, "Mungo Carstairs" <[email protected]<mailto:[email protected]>> escribió: Hi David, 95% ok but some things to tidy up! I've dumped all my findings as a comment to JAL-1428. Please have a look some time and let me know if anything isn't clear or you disagree. Thanks! Mungo On Thu, Sep 25, 2014 at 1:52 PM, Mungo Carstairs <[email protected]<mailto:[email protected]>> wrote: Hi David, I'll have a go with your branch and let you know if I spot anything algo que falta. Thanks, Mungo ________________________________ From: [email protected]<mailto:[email protected]> <[email protected]<mailto:[email protected]>> on behalf of David Roldán Martínez <[email protected]<mailto:[email protected]>> Sent: 23 September 2014 17:32 To: Jalview Development List Subject: [Jalview-dev] i18n review for 2.8.2 Hi all, I've just fixed all the i18n bugs I've found for 2.8.2. They're commited at Release_2_8_2_Branch_i18n (http://source.jalview.org/gitweb/?p=jalview.git;a=shortlog;h=refs/heads/Release_2_8_2_Branch_i18n). Although I've made some basic tests before to commit, I'm not an advanced Jalview user and thus I would appreciate if anybody checkouts branch code and make further tests. If, additionally, these tests are documented at wiki, for future releases I'l be able to do them on my own. :) Now I'm going to work with translations. Let's see Jalview speaking more languages!!!! Cheers, David The University of Dundee is a registered Scottish Charity, No: SC015096 _______________________________________________ Jalview-dev mailing list [email protected]<mailto:[email protected]> http://www.compbio.dundee.ac.uk/mailman/listinfo/jalview-dev _______________________________________________ Jalview-dev mailing list [email protected]<mailto:[email protected]> http://www.compbio.dundee.ac.uk/mailman/listinfo/jalview-dev _______________________________________________ Jalview-dev mailing list [email protected]<mailto:[email protected]> http://www.compbio.dundee.ac.uk/mailman/listinfo/jalview-dev _______________________________________________ Jalview-dev mailing list [email protected]<mailto:[email protected]> http://www.compbio.dundee.ac.uk/mailman/listinfo/jalview-dev _______________________________________________ Jalview-dev mailing list [email protected]<mailto:[email protected]> http://www.compbio.dundee.ac.uk/mailman/listinfo/jalview-dev _______________________________________________ Jalview-dev mailing list [email protected]<mailto:[email protected]> http://www.compbio.dundee.ac.uk/mailman/listinfo/jalview-dev _______________________________________________ Jalview-dev mailing list [email protected]<mailto:[email protected]> http://www.compbio.dundee.ac.uk/mailman/listinfo/jalview-dev _______________________________________________ Jalview-dev mailing list [email protected]<mailto:[email protected]> http://www.compbio.dundee.ac.uk/mailman/listinfo/jalview-dev The University of Dundee is a registered Scottish Charity, No: SC015096
_______________________________________________ Jalview-dev mailing list [email protected] http://www.compbio.dundee.ac.uk/mailman/listinfo/jalview-dev
