> I'll test patches, but I'm *not* going to re-configure by myself to make
them work
> If a patch nees a certain configuration to perform correctly, patch config
as well.
Danny, how do you propose testing on your end? I don't think that
reconfiguring "by yourself" is called for, but Peter believes that he DID
patch config. Are you willing to post your XML files either to the list or
perhaps to Peter? If there is a problem to be fixed, it first starts with
properly identifying the problem, and then correcting it.
> why the hell can't we have a watchdog replacement for the scheduler,
> and leave out the refactoring?
Shooting from the hip, putting Andrei's and Peter's implementation under the
Scheduler interface means writing a set of adapter classes, and then doing a
hashmap lookup each time you want to reset the timer (because the Scheduler
interface specifies that you don't interact with a timer, you interact with
a manager of timers). If the issue is about implementation, I don't see
that this buys us anything.
My argument is the opposite: put both of them under the Watchdog interface,
for reasons I've stated before.
For example, the vital issue of testing. We need to test both the
non-timeout and timeout cases work, as I've done when writing the same type
of code in the past, and would consider normative for any such class.
For example, the run method for Harmeet's scheduler is:
public void run() {
while ( Thread.currentThread().isInterrupted() ) {
...
}
}
Hello! While IS interrupted? For those not familar with this method:
* Tests whether the current thread has been interrupted.
* @return true if the current thread has been interrupted;
* false otherwise.
In other words, this code exits immediately upon startup. Even if we don't
spot errors like this desk checking, this is why we need to unit test as
much as possible, and test BOTH sides of conditions.
We can more easliy unit test the Watchdog interface because we can easily
code a standalone driver than anyone can run on any implementation of it.
Andrei and Peter's Watchdog code is standalone. Harmeet's code could also
be standalone, at the core. His core implementation doesn't really need
Avalon Frameworks.
--- Noel
--
To unsubscribe, e-mail: <mailto:[EMAIL PROTECTED]>
For additional commands, e-mail: <mailto:[EMAIL PROTECTED]>
