Hi Harmeet, Please hold off on the Commit of the DnsJava upgrade, I am still cleaning/clearing up a few things with Noel and we should have a new version of the Patch in a couple of days.
May I ask what the problem is with Wildcard imports? Is it simpley an estetical/readability issue? Are you suggesting that we remove the <authoritative> config option? Thanks, Sergei ----- Original Message ----- From: "Harmeet Bedi" <[EMAIL PROTECTED]> To: "James Developers List" <[EMAIL PROTECTED]> Sent: Saturday, January 18, 2003 8:22 PM Subject: Re: [PATCH] Upgrade to DnsJava 1.3.1, add DNS Server autodetect, Make use of higher level api > Looks good but a few minor things > - I don't think there is any need to change DNServer interface to return a > list instead of collection. The results obtained are already sorted > according to priority and there is no need to do any more sorting. The > results returned are a collection of IP address so not sure what List to > collection does. Would prefer backward compatible API unless there is a real > gain. > - 'PriorityClass' instead of 'priorityClass' for class name. > - Avoid wildcard import. > > Will commit it later today unless someone gets to it before. > > > One general question. Do we ever need to do autoritative lookups for MX > record ? Wouldn't that slow up. > > Harmeet > ----- Original Message ----- > From: "Serge Sozonoff" <[EMAIL PROTECTED]> > To: "James Developers List" <[EMAIL PROTECTED]> > Sent: Wednesday, January 15, 2003 6:05 AM > Subject: [PATCH] Upgrade to DnsJava 1.3.1, add DNS Server autodetect, Make > use of higher level api > > > > Hi All, > > > > Attached is a patch to upgrade to DnsJava 1.3.1 > > The Patch also adds DNS Server autodetect, simplifys some code and takes > > care of some TODO items. > > > > DnsJava brings several bug fixes, the ChangeLog can be found here though > for > > some reason it only includes changes up > > until version 1.3.0 (http://www.xbill.org/dnsjava/Changelog) > > > > As fare as DNS autodetect goes, currently, this works if the OS has a > > unix-like /etc/resolv.conf, or the system is Windows based with ipconfig > or > > winipcfg. > > > > I am a little mixed up with the exact way we intend to handle to 2.1 > branch > > so this patch was made against HEAD. > > > > Thanks, > > Sergei > > > > > > > > > -------------------------------------------------------------------------- -- > ---- > > > > -- > > To unsubscribe, e-mail: > <mailto:[EMAIL PROTECTED]> > > For additional commands, e-mail: > <mailto:[EMAIL PROTECTED]> > > > -- > To unsubscribe, e-mail: <mailto:[EMAIL PROTECTED]> > For additional commands, e-mail: <mailto:[EMAIL PROTECTED]> > > -- To unsubscribe, e-mail: <mailto:[EMAIL PROTECTED]> For additional commands, e-mail: <mailto:[EMAIL PROTECTED]>
