[
https://issues.apache.org/jira/browse/LUCENE-894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12500005
]
Michael Busch commented on LUCENE-894:
--------------------------------------
> minor notes...
Thanks for reviewing!
> 1) common-build.xml is a better name then "build-common.xml" like some
> other projects use because auto completion of file names on "b..." only
> result in build.xml ... perhaps this new file could be "demo-build.xml"
I see - will do.
> 2) as i recall, older versions of ant don't include the targets from
> imported files, but newer versions do ... the only way i know to supress
> them is to no provide them a description, which doesn't work well sicne
> we want them to have descriptions when imported by build.xml. a simple
> solution may be to keep the demo-build.xml file extremly simple, with no
> imports, and use <ant> or <antcall> to exec targets in common-build.xml
> (perhaps even new targets written explicitly for the demo)
If we want to use <ant> we have to move the demo targets from build.xml
to common-build.xml. And demo-build.xml would have to overwrite some of
the properties of common-build.xml like the classpath of the core
classes, because build.xml builds from the sources, whereas demo-build.xml
has to use the binary jar file.
Actually I don't even need to import any targets from common-build.xml in
demo-build.xml, all I need are some properties like version and build dir.
A simpler solution which comes to my mind is it therefore to add a new
file common-build.properties and to move some properties from
common-build.xml to this new file. Then common-build.xml and
demo-build.xml import the properties file and we're fine. I tried this out
already and it seems to work fine. I will attach a patch with this
approach. Would be nice if you could take another look, Hoss! (others are
welcome too of course!)
> Custom build.xml for binary distributions
> -----------------------------------------
>
> Key: LUCENE-894
> URL: https://issues.apache.org/jira/browse/LUCENE-894
> Project: Lucene - Java
> Issue Type: Bug
> Components: Build
> Affects Versions: 2.1
> Reporter: Michael Busch
> Assignee: Michael Busch
> Priority: Minor
> Fix For: 2.2
>
> Attachments: lucene-894.patch
>
>
> The binary files of a distribution come with the demo sources
> and a build.xml file. However, the build.xml doesn't work for
> the binary distribution, so it can't be used to build the
> demos.
> This problem was notices the first time when release 2.1 was
> made. Before we ship 2.2 we should fix this.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
