[
https://issues.apache.org/jira/browse/LUCENE-894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12501081
]
Michael Busch commented on LUCENE-894:
--------------------------------------
> I couldn't help but make a few tweaks...
Thanks for reviewing!
> 1) used a filterset to do the token replacements as part of hte copy
> (isntead of after the fact)
Neat!
> 2) since the demo build file is now just a template (and can't be run
> until it's pacakged) it now seems more like "source" then part of the
> build system, so i moved it into "src/demo" (which has the added benefit
> of keeping the root dir a little cleaner)
Good! Yes I agree that src/demo is a better place for the template file.
> Custom build.xml for binary distributions
> -----------------------------------------
>
> Key: LUCENE-894
> URL: https://issues.apache.org/jira/browse/LUCENE-894
> Project: Lucene - Java
> Issue Type: Bug
> Components: Build
> Affects Versions: 2.1
> Reporter: Michael Busch
> Assignee: Michael Busch
> Priority: Minor
> Fix For: 2.2
>
> Attachments: lucene-894.patch, lucene-894.patch, lucene-894.patch,
> lucene-894.patch, lucene-894.patch
>
>
> The binary files of a distribution come with the demo sources
> and a build.xml file. However, the build.xml doesn't work for
> the binary distribution, so it can't be used to build the
> demos.
> This problem was notices the first time when release 2.1 was
> made. Before we ship 2.2 we should fix this.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
