[ 
https://issues.apache.org/jira/browse/LUCENE-894?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Busch updated LUCENE-894:
---------------------------------

    Attachment: lucene-894.patch

After updating my patch to the current trunk I noticed that something is
not working correctly. It seems that the build.xml files of the contrib
modules that import common-build.xml don't import the properties correctly
that I moved to the new properties file. I actually have no idea why.

But I'm not desperate yet ;) and I got a new idea how to do this more
elegant: In this new patch I add a file to the root dir called
demo-build.template which has placeholder strings for the property values
that are needed in the build.xml file of the binary package like 
"version". While packaging this template file becomes copied to the build
dir and via the ant task <replace> the placeholder strings are replaced by
the actual values. Then this file is included as build.xml in the binary
packages. 

The advantage of this approach is that we don't have to include 
common-build.xml or a property file in the binaries. Just a very simple 
build.xml is included with the 4 targets "clean", "compile-demo",
"jar-demo", "war-demo". I decided not to dig into the problem with the 
previous patch described above because I believe this is the better 
approach. Thoughts?

> Custom build.xml for binary distributions
> -----------------------------------------
>
>                 Key: LUCENE-894
>                 URL: https://issues.apache.org/jira/browse/LUCENE-894
>             Project: Lucene - Java
>          Issue Type: Bug
>          Components: Build
>    Affects Versions: 2.1
>            Reporter: Michael Busch
>            Assignee: Michael Busch
>            Priority: Minor
>             Fix For: 2.2
>
>         Attachments: lucene-894.patch, lucene-894.patch, lucene-894.patch
>
>
> The binary files of a distribution come with the demo sources
> and a build.xml file. However, the build.xml doesn't work for
> the binary distribution, so it can't be used to build the 
> demos.
> This problem was notices the first time when release 2.1 was
> made. Before we ship 2.2 we should fix this.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to