Hi Mike, I think we can simulate the support of just "A" or just "B" if we support "A or B, whichever comes first": for someone just wants ramBufferSize limit, he can set maxBufferedDocs/maxBufferedDeleteTerms to max int; for ParallelReader, ramBufferSize can be set to max int MB.
Ning On 9/24/07, Michael McCandless <[EMAIL PROTECTED]> wrote: > > "Doron Cohen" <[EMAIL PROTECTED]> wrote: > > Hi Ning, > > > > "Ning Li" <[EMAIL PROTECTED]> wrote on 24/09/2007 00:26:36: > > > > > Do you mean to make maxBufferedDocs/maxBufferedDeleteTerms and > > > ramBufferSize take effect at the same time? That is, a flush is > > > triggered whenever one of the limits is reached? I think it's > > > reasonable. If we make that change, we should also change a few > > > default values to provide good out-of-box performance. > > > > Yes that's what I meant - this way all these limits apply, but for > > different purposes: maxBufferedDocs/maxBufferedDeleteTerms for availability > > (of recent changes) for search considerations, and ramBufferSize for memory > > limits considerations. > > But, we have to be careful for the ParallelReader use case: for this > case you only want to trigger flushing by doc count (ie, never by > RAM), right? > > It seems like sometimes we want "A or B, whichever comes first" but other > times either just "A" or just "B". > > Mike > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [EMAIL PROTECTED] > For additional commands, e-mail: [EMAIL PROTECTED] > > --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
