[ https://issues.apache.org/jira/browse/LUCENE-1678?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12718080#action_12718080 ]
Michael McCandless commented on LUCENE-1678: -------------------------------------------- bq. The way Lucene stuff generally goes, if someone like Grant or Mike really wanted to push changes, the changes would happen. Well, it's consensus that we all need to reach (at least enough consensus to vote on it), and on complex topics it's not easy to get to consensus. bq. Giving up is really not the answer though - thats why the discussion has come and gone in the past. I don't think anyone has given up. The issue still smoulders and flares up here and there (like, this issue). Eventually we'll get enough consensus for something concrete to change. bq. I have no moral right to hammer my ideals into heads that did tremendously more for the project, than I did. In fact you do & should. This is exactly how change happens. Here's a great (though sexist) quote: "The reasonable man adapts himself to the world; the unreasonable one persists to adapt the world to himself. Therefore all progress depends on the unreasonable man." - George Bernard Shaw > Deprecate Analyzer.tokenStream > ------------------------------ > > Key: LUCENE-1678 > URL: https://issues.apache.org/jira/browse/LUCENE-1678 > Project: Lucene - Java > Issue Type: Bug > Components: Analysis > Reporter: Michael McCandless > Assignee: Michael McCandless > Priority: Minor > Fix For: 2.9 > > > The addition of reusableTokenStream to the core analyzers unfortunately broke > back compat of external subclasses: > > http://www.nabble.com/Extending-StandardAnalyzer-considered-harmful-td23863822.html > On upgrading, such subclasses would silently not be used anymore, since > Lucene's indexing invokes reusableTokenStream. > I think we should should at least deprecate Analyzer.tokenStream, today, so > that users see deprecation warnings if their classes override this method. > But going forward when we want to change the API of core classes that are > extended, I think we have to introduce entirely new classes, to keep back > compatibility. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. --------------------------------------------------------------------- To unsubscribe, e-mail: java-dev-unsubscr...@lucene.apache.org For additional commands, e-mail: java-dev-h...@lucene.apache.org