[ https://issues.apache.org/jira/browse/LUCENE-1794?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12741601#action_12741601 ]
Robert Muir edited comment on LUCENE-1794 at 8/10/09 3:46 PM: -------------------------------------------------------------- I am thinking of expanding this patch to include reset() impls for state-keeping tokenizers/filters that do not currently have an analyzer... not really part of this issue but it presents an issue for someone trying to create a custom analyzer (with reusableTS) based on these components. was (Author: rcmuir): I am thinking of expanding this patch to include reset() impls for tokenizers/filters that do not currently have an analyzer... not really part of this issue but it presents an issue for someone trying to create a custom analyzer based on these components. > implement reusableTokenStream for all contrib analyzers > ------------------------------------------------------- > > Key: LUCENE-1794 > URL: https://issues.apache.org/jira/browse/LUCENE-1794 > Project: Lucene - Java > Issue Type: Improvement > Components: contrib/analyzers > Reporter: Robert Muir > Assignee: Robert Muir > Priority: Minor > Fix For: 2.9 > > Attachments: LUCENE-1794.patch, LUCENE-1794.patch > > > most contrib analyzers do not have an impl for reusableTokenStream > regardless of how expensive the back compat reflection is for indexing speed, > I think we should do this to mitigate any performance costs. hey, overall it > might even be an improvement! > the back compat code for non-final analyzers is already in place so this is > easy money in my opinion. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. --------------------------------------------------------------------- To unsubscribe, e-mail: java-dev-unsubscr...@lucene.apache.org For additional commands, e-mail: java-dev-h...@lucene.apache.org