[
https://issues.apache.org/jira/browse/LUCENE-1794?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12741805#action_12741805
]
Robert Muir commented on LUCENE-1794:
-------------------------------------
{quote}
Now the problem: TokenStream.reset() has different semantics than what we are
using it for here. CachingTokenFilter uses it to start the replay of the last
string of tokens it saw (definitely bad for reuse).
{quote}
Hmm, I have not looked at CachingTokenFilter, sounds like an issue there.
In this case I was referring to state-keeping tokenizers/filters without
reset() impls in contrib: Ngram, shingles, things like that.
I looked at the core tokenstreams and most of those seemed to properly support
it... I guess we have one exception
> implement reusableTokenStream for all contrib analyzers
> -------------------------------------------------------
>
> Key: LUCENE-1794
> URL: https://issues.apache.org/jira/browse/LUCENE-1794
> Project: Lucene - Java
> Issue Type: Improvement
> Components: contrib/analyzers
> Reporter: Robert Muir
> Assignee: Robert Muir
> Priority: Minor
> Fix For: 2.9
>
> Attachments: LUCENE-1794.patch, LUCENE-1794.patch
>
>
> most contrib analyzers do not have an impl for reusableTokenStream
> regardless of how expensive the back compat reflection is for indexing speed,
> I think we should do this to mitigate any performance costs. hey, overall it
> might even be an improvement!
> the back compat code for non-final analyzers is already in place so this is
> easy money in my opinion.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: java-dev-h...@lucene.apache.org
