Heh :) Though... that was different, because that code hadn't been created yet (I think) and so you were asking whether you could use 1.5. The added work & cost of sticking with 1.4 was basically zero.
Whereas in this case we have new and useful functionality (the new "fast vector highlighter") that we'll have to pull, and, I don't think anyone will make the effort to fix the new highlighter to be 1.5. Ie, for this case (since we'll lose something) it's compelling to now accept 1.5 for benchmark. Mike On Thu, Aug 13, 2009 at 12:03 PM, Michael McCandless<luc...@mikemccandless.com> wrote: > I could go for that as well :) > > Mike > > On Thu, Aug 13, 2009 at 12:02 PM, Mark Miller<markrmil...@gmail.com> wrote: >> I'd almost just say Benchmark is 1.5 now. We try to keep contrib things that >> are 1.4 at 1.4, but why bend over backwards here to pull that task out? >> Technically there is no back compat promise here. >> >> The number of people relying on 1.4 for Benchmark has got to be ... >> >> >> Michael McCandless wrote: >>> >>> Sigh. I guess we have to pull that task for 2.9. >>> >>> I'll reopen the original issue (LUCENE-1773), note this, and mark it >>> as fix for 3.0. >>> >>> Mike >>> >>> On Thu, Aug 13, 2009 at 11:24 AM, Shai Erera<ser...@gmail.com> wrote: >>> >>>> >>>> Me too ... and you were suggesting to hold off w/ 3.0 and having 2.5 and >>>> then 2.9 ... :). >>>> >>>> What do you think I should do w/ that task in the meantime? >>>> >>>> Shai >>>> >>>> On Thu, Aug 13, 2009 at 6:21 PM, Grant Ingersoll <gsing...@apache.org> >>>> wrote: >>>> >>>>> >>>>> I _so_ can't wait to have this one off of our back for a while. Of >>>>> course, then we'll have 1.6 creep... ;-) >>>>> >>>>> On Aug 13, 2009, at 9:15 AM, Shai Erera wrote: >>>>> >>>>> >>>>>> >>>>>> I up SVN and noticed some compilation errors in my eclipse in >>>>>> SearchTravRetVectorHighlightTask. I added FastVectorHighlighter to my >>>>>> build >>>>>> path, but it failed again because the latter is Java 1.5 compliant, and >>>>>> I >>>>>> set the compiler level to 1.4 (to comply w/ core and benchmark level). >>>>>> >>>>>> Maybe this task should be put aside until we upgrade benchmark to 1.5? >>>>>> >>>>>> Shai >>>>>> >>>>> >>>>> --------------------------------------------------------------------- >>>>> To unsubscribe, e-mail: java-dev-unsubscr...@lucene.apache.org >>>>> For additional commands, e-mail: java-dev-h...@lucene.apache.org >>>>> >>>>> >>>> >>>> >>> >>> --------------------------------------------------------------------- >>> To unsubscribe, e-mail: java-dev-unsubscr...@lucene.apache.org >>> For additional commands, e-mail: java-dev-h...@lucene.apache.org >>> >>> >> >> >> -- >> - Mark >> >> http://www.lucidimagination.com >> >> >> >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: java-dev-unsubscr...@lucene.apache.org >> For additional commands, e-mail: java-dev-h...@lucene.apache.org >> >> > --------------------------------------------------------------------- To unsubscribe, e-mail: java-dev-unsubscr...@lucene.apache.org For additional commands, e-mail: java-dev-h...@lucene.apache.org
