[
https://issues.apache.org/jira/browse/LUCENE-2110?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Uwe Schindler updated LUCENE-2110:
----------------------------------
Attachment: LUCENE-2110.patch
New patch that implements the Attributes implementation to power scoring
BooleanQuery searches. It changes:
- MTQ.getTermsEnum now returns TermsEnum no longer a filtered one
- As in flex, MTQ can only work on one field (because TermsEnum is limited to
one Field), it gets a getField() method (highlighter is happy) and a ctor to
set this final field (protected). Removed all thoise methods from sub classes.
Old classes that still use TermEnum and call the deprec default ctor, still
work (because the field is returned in the FilteredTermEnum), but highligter
gots no field then (null). Whne BW is removed, highlighter do not need to use
FakeIndexReader anymore.
- WildcardQuery/PrefixQuery/TermRangeQuery was optimized to no longer rewrite,
but just return the correct enum in getEnum/getTermsEnum(). The special cases
for these queries are match all (directly return the enum from reader - new!!!,
nothing EmptyTermsEnum, or SingleTermsEnum)
- Fixed Highlighter for MTQ.getField()
- FuzzyQuery now uses an attribute for the term difference:
MTQ.TermDifferenceAttribute. For scoring booolean rewrite it is added by the
consumer and keeps 1 per default, but fuzzy enum also adds it in its ctor and
sets in accept()). Also the PQ boolean rewrite mode is now a RewriteMode.
I think thats all. Happy reviewing.
> Change FilteredTermsEnum to work like Iterator, so it is not positioned and
> next() must be always called first. Remove empty()
> ------------------------------------------------------------------------------------------------------------------------------
>
> Key: LUCENE-2110
> URL: https://issues.apache.org/jira/browse/LUCENE-2110
> Project: Lucene - Java
> Issue Type: Improvement
> Components: Search
> Affects Versions: Flex Branch
> Reporter: Uwe Schindler
> Assignee: Uwe Schindler
> Fix For: Flex Branch
>
> Attachments: LUCENE-2110.patch, LUCENE-2110.patch, LUCENE-2110.patch,
> LUCENE-2110.patch, LUCENE-2110.patch
>
>
> FilteredTermsEnum is confusing as it is initially positioned to the first
> term. It should instead work like an uninitialized TermsEnum for a field
> before the first call to next() or seek().
> Also document that not all FilteredTermsEnums may implement seek() as eg. NRQ
> or Automaton are not able to support this. Seeking is also not needed for MTQ
> at all, so seek can just throw UOE.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: java-dev-h...@lucene.apache.org
