[
https://issues.apache.org/jira/browse/LUCENE-2110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12786663#action_12786663
]
Michael McCandless commented on LUCENE-2110:
--------------------------------------------
Patch looks good Uwe -- just TestWildcard.testPrefixTerm, on back-compat tests,
that's failing. This is a nice simplification of MTQs...
I'm wondering if we can further simplify the "seek" case in FilteredTermsEnum
so that it's not a 2 step process (FTE.accept returns YES|NO_AND_SEEK, then,
FTE.next calls nextSeekTerm), ie instead accept would return the new seek term
in the returned status. This would also make the interaction between FTE and
its subclass stateless. But let's take that up under a separate issue. I
think this one is ready to go into flex branch?
> Change FilteredTermsEnum to work like Iterator, so it is not positioned and
> next() must be always called first. Remove empty()
> ------------------------------------------------------------------------------------------------------------------------------
>
> Key: LUCENE-2110
> URL: https://issues.apache.org/jira/browse/LUCENE-2110
> Project: Lucene - Java
> Issue Type: Improvement
> Components: Search
> Affects Versions: Flex Branch
> Reporter: Uwe Schindler
> Assignee: Uwe Schindler
> Fix For: Flex Branch
>
> Attachments: LUCENE-2110.patch, LUCENE-2110.patch, LUCENE-2110.patch,
> LUCENE-2110.patch, LUCENE-2110.patch
>
>
> FilteredTermsEnum is confusing as it is initially positioned to the first
> term. It should instead work like an uninitialized TermsEnum for a field
> before the first call to next() or seek().
> Also document that not all FilteredTermsEnums may implement seek() as eg. NRQ
> or Automaton are not able to support this. Seeking is also not needed for MTQ
> at all, so seek can just throw UOE.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: java-dev-h...@lucene.apache.org
