[ https://issues.apache.org/jira/browse/LUCENE-2195?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Simon Willnauer updated LUCENE-2195: ------------------------------------ Attachment: LUCENE-2195.patch Updated patch. This patch does not count==0 check in contains(Object) as the o.toString() could return null and the NPE would be silently swallowed if the set is empty. The null check and NPE are necessary to yield consistent behavior no matter if the set is empty or not. > Speedup CharArraySet if set is empty > ------------------------------------ > > Key: LUCENE-2195 > URL: https://issues.apache.org/jira/browse/LUCENE-2195 > Project: Lucene - Java > Issue Type: Improvement > Components: Analysis > Reporter: Simon Willnauer > Fix For: 3.1 > > Attachments: LUCENE-2195.patch, LUCENE-2195.patch > > > CharArraySet#contains(...) always creates a HashCode of the String, Char[] or > CharSequence even if the set is empty. > contains should return false if set it empty -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. --------------------------------------------------------------------- To unsubscribe, e-mail: java-dev-unsubscr...@lucene.apache.org For additional commands, e-mail: java-dev-h...@lucene.apache.org