[
https://issues.apache.org/jira/browse/LUCENE-2195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12797692#action_12797692
]
Yonik Seeley commented on LUCENE-2195:
--------------------------------------
Seems that this patch would just slow things down (slightly) for the common
case, and for correctly written code.
If one really wants to optimize the case of an empty set, shouldn't that be
done at a higher level (i.e. don't put the stop filter in the chain, don't
create a set at all, etc).
So I think we should skip both the null checks and the ==0 checks and leave it
as is.
> Speedup CharArraySet if set is empty
> ------------------------------------
>
> Key: LUCENE-2195
> URL: https://issues.apache.org/jira/browse/LUCENE-2195
> Project: Lucene - Java
> Issue Type: Improvement
> Components: Analysis
> Reporter: Simon Willnauer
> Fix For: 3.1
>
> Attachments: LUCENE-2195.patch, LUCENE-2195.patch
>
>
> CharArraySet#contains(...) always creates a HashCode of the String, Char[] or
> CharSequence even if the set is empty.
> contains should return false if set it empty
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: java-dev-h...@lucene.apache.org
