[ https://issues.apache.org/jira/browse/LUCENE-2195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12797710#action_12797710 ]
Robert Muir commented on LUCENE-2195: ------------------------------------- well then something must be decided: either we use null sets,remove use of EMPTY_SET all over the place, and have if set != null scattered all over the place, or we go this route. i do not care either way but we should not be using EMPTY_SET in various tokenstreams without this patch, else we unnecessarily hash every input token for no good reason. > Speedup CharArraySet if set is empty > ------------------------------------ > > Key: LUCENE-2195 > URL: https://issues.apache.org/jira/browse/LUCENE-2195 > Project: Lucene - Java > Issue Type: Improvement > Components: Analysis > Reporter: Simon Willnauer > Fix For: 3.1 > > Attachments: LUCENE-2195.patch, LUCENE-2195.patch > > > CharArraySet#contains(...) always creates a HashCode of the String, Char[] or > CharSequence even if the set is empty. > contains should return false if set it empty -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. --------------------------------------------------------------------- To unsubscribe, e-mail: java-dev-unsubscr...@lucene.apache.org For additional commands, e-mail: java-dev-h...@lucene.apache.org