On Wed, 16 Jun 2021 17:18:31 GMT, Jonathan Gibbons <j...@openjdk.org> wrote:
>> Please review an update to add a new method in Reporter to report a >> diagnostic within a DocTree node for those DocTree nodes that wrap a string. >> >> This is the last of the current round of updates to improve the diagnostics >> that can be generated by javadoc. >> >> The general fix, in JavadocLog and Reporter, is pretty simple, given all the >> improvements in recent related changes. >> >> There are some cosmetic cleanups that were made while exploring the current >> solution. >> >> The test is "reasonably thorough" and uses a custom taglet to generate >> diagnostics for selected nodes in doc comment trees. The test then >> "algorithmically validates" (i.e. no golden files or text blocks) the >> diagnostics that are either passed to a DiagnosticListener or written to the >> console stream. > > Jonathan Gibbons has updated the pull request incrementally with one > additional commit since the last revision: > > Address review feedback Shouldn't this change also add a corresponding method to `jdk.javadoc.internal.doclets.toolkit.Messages` similarly to how it was done for `Reporter.print(Diagnostic.Kind, FileObject, int, int, int, String)`? ------------- PR: https://git.openjdk.java.net/jdk/pull/4489
