> Please review an update to add a new method in Reporter to report a > diagnostic within a DocTree node for those DocTree nodes that wrap a string. > > This is the last of the current round of updates to improve the diagnostics > that can be generated by javadoc. > > The general fix, in JavadocLog and Reporter, is pretty simple, given all the > improvements in recent related changes. > > There are some cosmetic cleanups that were made while exploring the current > solution. > > The test is "reasonably thorough" and uses a custom taglet to generate > diagnostics for selected nodes in doc comment trees. The test then > "algorithmically validates" (i.e. no golden files or text blocks) the > diagnostics that are either passed to a DiagnosticListener or written to the > console stream.
Jonathan Gibbons has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains five additional commits since the last revision: - Update Reporter spec; add methods to Messages - Merge remote-tracking branch 'upstream/master' into 8268420.Reporter-DocTree-pos - Merge remote-tracking branch 'upstream/master' into 8268420.Reporter-DocTree-pos - Address review feedback - JDK-8268420 new Reporter method to report a diagnostic within a DocTree node ------------- Changes: - all: https://git.openjdk.java.net/jdk/pull/4489/files - new: https://git.openjdk.java.net/jdk/pull/4489/files/e3d9721b..01dcf69e Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=4489&range=02 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=4489&range=01-02 Stats: 87063 lines in 1538 files changed: 45584 ins; 34440 del; 7039 mod Patch: https://git.openjdk.java.net/jdk/pull/4489.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/4489/head:pull/4489 PR: https://git.openjdk.java.net/jdk/pull/4489
