> Please review an update to add a new method in Reporter to report a 
> diagnostic within a DocTree node for those DocTree nodes that wrap a string.
> 
> This is the last of the current round of updates to improve the diagnostics 
> that can be generated by javadoc.
> 
> The general fix, in JavadocLog and Reporter, is pretty simple, given all the 
> improvements in recent related changes.
> 
> There are some cosmetic cleanups that were made while exploring the current 
> solution.
> 
> The test is "reasonably thorough" and uses a custom taglet to generate 
> diagnostics for selected nodes in doc comment trees. The test then 
> "algorithmically validates" (i.e. no golden files or text blocks) the 
> diagnostics that are either passed to a DiagnosticListener or written to the 
> console stream.

Jonathan Gibbons has updated the pull request incrementally with one additional 
commit since the last revision:

  change @implNote to @implSpec

-------------

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/4489/files
  - new: https://git.openjdk.java.net/jdk/pull/4489/files/01dcf69e..1ac79630

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=4489&range=03
 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=4489&range=02-03

  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.java.net/jdk/pull/4489.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/4489/head:pull/4489

PR: https://git.openjdk.java.net/jdk/pull/4489

Reply via email to