On Fri, 28 Oct 2022 18:46:59 GMT, Jonathan Gibbons <j...@openjdk.org> wrote:
>> Pavel Rappo has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 49 commits: >> >> - refactor: improve error handling >> - refactor: clarify, reuse, simplify, clean up >> - refactor: pass Utils & BaseConfiguration to taglet >> >> This simplifies lots of methods. Later this could be done for other >> taglets too. >> - refactor: better code comments >> - refactor: add more relevant excerpts from JLS >> - fix: introduce more control to search >> >> This is done for the sake of `@throws`. Two convenience methods are >> added to assist migration from Optional with minimal change to >> DocFinder call sites. >> >> This solves 8295800: When searching documentation for an exception, >> don't jump over methods that don't mention that exception. >> - refactor: clean up ThrowsTaglet >> - Merge branch 'master' into HEAD >> - fix: test failed due to filesystem handling issues >> >> Filed 8295543 to track that filesystem issue and fixed the test to make >> sure the package cannot be confused with the type parameter, whose >> name is not pertinent to the test anyway. >> - Merge branch 'master' into 8285488 >> - ... and 39 more: https://git.openjdk.org/jdk/compare/628820f4...c2db1ae6 > > src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/taglets/ThrowsTaglet.java > line 196: > >> 194: messages.warning(path, >> "doclet.throwsInheritDocUnsupported"); >> 195: } else if (f instanceof Failure.Undocumented e) { >> 196: messages.warning(ch.getDocTreePath(e.tag()), >> "doclet.inheritDocNoDoc", diagnosticDescriptionOf(e.exceptionElement)); > > I'm thinking that 4 of these warnings, except maybe the last one, should be > upgraded to errors. Agreed, using errors here would be better than using warnings: errors are both more useful and simpler to implement. What stopped me initially from doing that is backward compatibility. Other (non-JDK) clients might find errors too prohibitive. ------------- PR: https://git.openjdk.org/jdk/pull/10746
